Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commandline-usage: separate stand-alone + initial ledger options #2010

Merged
merged 4 commits into from
Aug 11, 2023

Conversation

intelliot
Copy link
Contributor

Clarify: Initial Ledger Options is not a subcategory of Stand-Alone Mode Options

@thejohnfreeman @mtrippled @pwang200

…dent

Initial Ledger Options is not a subcategory of Stand-Alone Mode Options
@@ -70,7 +70,7 @@ Daemon mode is the default mode of operation for `rippled`. In addition to the [

The following option has been removed: `--validateShards`. [Removed in: rippled 1.7.0][]

## Stand-Alone Mode Options
### Stand-Alone Mode Options

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

## Daemon Mode Options
has two ##. Should Stand-Alone Mode Options match that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With 4e625a2, updated so both are at the ## level

@intelliot intelliot requested a review from pwang200 July 19, 2023 21:05
@github-actions
Copy link

Link check report. 495072 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/stand-alone-vs-initial-ledger/

Style Report

1 similar comment
@github-actions
Copy link

Link check report. 495072 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/stand-alone-vs-initial-ledger/

Style Report

@mDuo13
Copy link
Collaborator

mDuo13 commented Jul 19, 2023

I'm not convinced that most of these options work meaningfully in networked mode. Most of the time, the server will disregard whatever initial ledger it loaded if its trusted validators are working on something completely different. In what cases are any of these settings useful in networked mode?

@mtrippled
Copy link
Contributor

--valid is useful to start the initial validator in a network that needs to be restarted, such as for testing, or something unthinkable.
--ledger can be used in the same type of circumstance to choose a specific ledger.

The logic for the fast_load config option uses the same code path as --load, but reads the disk in parallel.

I don't know if the others are useful in network mode.

@intelliot
Copy link
Contributor Author

note: conversations with the team suggest that these options are not only for standalone mode

@mDuo13
Copy link
Collaborator

mDuo13 commented Aug 8, 2023

Updated with new information to clarify the uses of these options for starting networks (devnets and sidechains included) as well as debugging.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Link check report. 495078 links checked.
2 broken links found:
File: out/ja/nft-collections.html Link: nftoken.html#分類群
File: out/ja/account_nfts.html Link: nftoken.html#分類群

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/stand-alone-vs-initial-ledger/

Style Report

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Link check report. 495078 links checked.
2 broken links found:
File: out/ja/nft-collections.html Link: nftoken.html#分類群
File: out/ja/account_nfts.html Link: nftoken.html#分類群

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/stand-alone-vs-initial-ledger/

Style Report

| `--replay` | Intended for debugging. Use with `--ledger` to replay a ledger close. Your server must have the ledger in question and its direct ancestor already in the ledger store. Using the previous ledger as a base, the server processes all the transactions in the specified ledger, resulting in a re-creation of the specified ledger. With a debugger, you can add breakpoints to analyze specific transaction processing logic. |
| `--start` | Intended for debugging. Start with a new genesis ledger that has all known amendments (except those the server is configured to vote against) enabled. This makes the functionality of those amendments available right away, instead of needing to wait two weeks for the [Amendment Process](amendments.html). |
| `--valid` | **DEPRECATED** Intended for debugging. Consider the initial ledger a valid network ledger even before fully syncing with the network. |
| `--load` | Use only the ledger store on disk when loading the initial ledger. |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we re-enabling the deprecated options (--load and --valid)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, my understanding is that those options are no longer considered to be deprecated

@intelliot
Copy link
Contributor Author

FWIW, I approve of the commits added by @mDuo13 above

@ckeshava
Copy link

ckeshava commented Aug 9, 2023 via email

@mDuo13
Copy link
Collaborator

mDuo13 commented Aug 11, 2023

Link checker failures are the same ones already fixed in #2041, so this is good to go

@mDuo13 mDuo13 merged commit b357203 into master Aug 11, 2023
1 of 2 checks passed
@mDuo13 mDuo13 deleted the stand-alone-vs-initial-ledger branch August 11, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants