Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ter-codes.md #2006

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Update ter-codes.md #2006

merged 2 commits into from
Aug 2, 2023

Conversation

intelliot
Copy link
Contributor

Current description is misleading given the actual meaning of most ter codes.

Context: XRPLF/rippled#4504

If and when terSUBMITTED is added to rippled, a badge indicating the relevant version could be added: e.g. [New in: rippled 1.12.0][] (if it is added in 1.12.0).

@intelliot intelliot mentioned this pull request Jul 18, 2023
Merged
2 tasks
@github-actions
Copy link

Link check report. 495073 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/ter-submitted/

Style Report

@mtrippled
Copy link
Contributor

@intelliot Should these descriptions mirror those in https://github.com/XRPLF/rippled/blob/develop/src/ripple/protocol/TER.h#L41-L248 ?

@intelliot
Copy link
Contributor Author

@intelliot Should these descriptions mirror those in https://github.com/XRPLF/rippled/blob/develop/src/ripple/protocol/TER.h#L41-L248 ?

Sure, why not?

@mtrippled
Copy link
Contributor

@intelliot Should these descriptions mirror those in https://github.com/XRPLF/rippled/blob/develop/src/ripple/protocol/TER.h#L41-L248 ?

Sure, why not?

I went ahead and updated the ter* comments in rippled source accordingly on the "periodic" PR: XRPLF/rippled#4505

mDuo13
mDuo13 requested changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good improvements although I have one requirement to maintain

content/references/protocol-reference/transactions/transaction-results/ter-codes.md Outdated

| Code | Explanation |
|:-----------------|:----------------------------------------------------------|
| `terFUNDS_SPENT` | **DEPRECATED.** |
| `terSUBMITTED` | Transaction has been submitted, but not yet applied. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codes were in alphabetical order before. I'd like to keep that, just so it's easier to find the result code you're looking for.

Copy link
Contributor Author

@intelliot intelliot Jul 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think terRETRY was in the wrong order before. Anyway, fixed!

@github-actions
Copy link

Link check report. 495073 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/ter-submitted/

Style Report

@mDuo13 mDuo13 merged commit 2f394e0 into master Aug 2, 2023
2 checks passed
@mDuo13 mDuo13 deleted the ter-submitted branch August 2, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinr1234 justinr1234 justinr1234 approved these changes

@mDuo13 mDuo13 mDuo13 approved these changes

@ckniffen ckniffen Awaiting requested review from ckniffen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@intelliot @mtrippled @justinr1234 @mDuo13