Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New iconset #1925

Merged
merged 9 commits into from
Jul 12, 2023
Merged

New iconset #1925

merged 9 commits into from
Jul 12, 2023

Conversation

AKCodez
Copy link
Contributor

@AKCodez AKCodez commented Jun 1, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Link check report. 467224 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/new-iconset/

Style Report

@AKCodez AKCodez marked this pull request as ready for review July 3, 2023 18:11
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Link check report. 495071 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/new-iconset/

Style Report

mDuo13
mDuo13 requested changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I build this locally, it looks like the changes to the up-right arrow cause it to clip out of the line for the external links in the docs sidebar. Take a look at client-libraries.html for some examples. The preview on github.io looks different, but I think that's probably a glitch of the staging build.

@AKCodez
Copy link
Contributor Author

AKCodez commented Jul 6, 2023

When I build this locally, it looks like the changes to the up-right arrow cause it to clip out of the line for the external links in the docs sidebar. Take a look at client-libraries.html for some examples. The preview on github.io looks different, but I think that's probably a glitch of the staging build.

I am experiencing the same issue, locally it is being displayed as expected but on the preview link it is showing the incorrect code, as for the the up right arrow clipping out of the line - I can not recreate this locally.

@github-actions
Copy link

Link check report. 495071 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/new-iconset/

Style Report

mDuo13
mDuo13 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good

@mDuo13 mDuo13 merged commit f7cf71e into master Jul 12, 2023
2 checks passed
@mDuo13 mDuo13 deleted the new-iconset branch July 12, 2023 21:32
@mDuo13 mDuo13 mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mDuo13 mDuo13 mDuo13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AKCodez @mDuo13