Skip to content

flags

Codecov / codecov/project succeeded Oct 8, 2024 in 0s

76.1% (target 60.0%)

View this Pull Request on Codecov

76.1% (target 60.0%)

Details

Codecov Report

Attention: Patch coverage is 77.95173% with 338 lines in your changes missing coverage. Please review.

Project coverage is 76.1%. Comparing base (bf4a7b6) to head (1cbf843).

Files with missing lines Patch % Lines
src/xrpld/app/tx/detail/VaultSet.cpp 0.0% 61 Missing ⚠️
src/libxrpl/protocol/STAmount.cpp 74.0% 45 Missing ⚠️
src/xrpld/rpc/handlers/LedgerEntry.cpp 5.9% 32 Missing ⚠️
src/xrpld/app/tx/detail/InvariantCheck.cpp 65.5% 30 Missing ⚠️
src/libxrpl/basics/MPTAmount.cpp 8.3% 22 Missing ⚠️
src/xrpld/app/tx/detail/Payment.cpp 85.4% 21 Missing ⚠️
src/libxrpl/protocol/STIssue.cpp 52.9% 16 Missing ⚠️
src/xrpld/ledger/detail/View.cpp 91.8% 13 Missing ⚠️
src/libxrpl/protocol/Asset.cpp 72.4% 8 Missing ⚠️
src/libxrpl/protocol/STNumber.cpp 73.3% 8 Missing ⚠️
... and 24 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5147     +/-   ##
=========================================
- Coverage     76.2%   76.1%   -0.1%     
=========================================
  Files          760     779     +19     
  Lines        61568   62706   +1138     
  Branches      8126    8280    +154     
=========================================
+ Hits         46898   47717    +819     
- Misses       14670   14989    +319     
Files with missing lines Coverage Δ
include/xrpl/basics/MPTAmount.h 100.0% <100.0%> (ø)
include/xrpl/basics/Number.h 100.0% <100.0%> (ø)
include/xrpl/basics/base_uint.h 97.2% <ø> (+0.6%) ⬆️
include/xrpl/protocol/AMMCore.h 100.0% <ø> (ø)
include/xrpl/protocol/AmountConversions.h 87.5% <100.0%> (ø)
include/xrpl/protocol/Feature.h 100.0% <ø> (ø)
include/xrpl/protocol/Indexes.h 100.0% <100.0%> (ø)
include/xrpl/protocol/Issue.h 100.0% <100.0%> (ø)
include/xrpl/protocol/MPTIssue.h 100.0% <100.0%> (ø)
include/xrpl/protocol/SField.h 100.0% <ø> (ø)
... and 77 more

... and 3 files with indirect coverage changes

Impacted file tree graph