Call python to upgrade pip in Windows CI #4768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximinez
added
CI
Bronek
approved these changes
Oct 16, 2023
ckeshava
approved these changes
Oct 16, 2023
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
In Windows, we need to call `python` in order for the `pip` upgrade command to work. This changes the GitHub Actions Windows CI job to use the correct command to upgrade PIP, fixing this error: ``` ERROR: To modify pip, please run the following command: C:\hostedtoolcache\windows\Python\3.9.13\x64\python.exe -m pip install --upgrade pip ``` A future task is to make job run on heavy Windows runners so that it doesn't take so long. Context: XRPLF#4596
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
The default
pipupgrade command doesn't work properly in Windows. It needs to callpythonto work.This PR, if merged, changes the Github Actions Windows CI job uses the correct command to upgrade PIP.
Context of Change
This CI run against develop failed because
pipwas unable to upgrade.The error indicated
I don't think this problem existed when the original, recently merged PR was open, and it was open for a long time, so you'd think we would have run into it.
Type of Change
Test Plan
No C++ code was changed. This only affects CI, so there is nothing to test.
Future Tasks
As mentioned in #4596, future tasks include making this job run on heavy Windows runners, so it doesn't take so dang long.