-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixPayChanV1 #4717
Open
dangell7
wants to merge
19
commits into
XRPLF:develop
Choose a base branch
from
Transia-RnD:fixPayChanV1
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+71
−15
Open
fixPayChanV1 #4717
Changes from 16 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8fccd90
fixPayChanV1
dangell7 10be4e8
Merge branch 'develop' into fixPayChanV1
dangell7 34eb379
Merge branch 'develop' into fixPayChanV1
dangell7 ac560ca
Merge branch 'develop' into fixPayChanV1
dangell7 e1d5b6d
Merge branch 'develop' into fixPayChanV1
dangell7 7852c20
Merge branch 'develop' into fixPayChanV1
dangell7 9db774e
Update PayChan.cpp
dangell7 43ccf98
Merge branch 'develop' into fixPayChanV1
dangell7 733e3ca
Merge branch 'develop' into fixPayChanV1
dangell7 50bbcd4
update test `tecEXPIRED`
dangell7 cb7e575
Update PayChan_test.cpp
dangell7 4db1218
Merge branch 'develop' into fixPayChanV1
dangell7 c5a59c8
Merge branch 'develop' into fixPayChanV1
dangell7 5496108
move after func to view.h
dangell7 66e9924
rename amendment `fixPayChanCancelAfter`
dangell7 16fc7b2
Merge branch 'develop' into fixPayChanV1
dangell7 d65afe7
move guard
dangell7 417a050
Merge branch 'develop' into fixPayChanV1
dangell7 d123ae7
Merge branch 'develop' into fixPayChanV1
dangell7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check should happen before the SLE is created - perhaps around line 250.