Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XLS-0073d AMMClawback #233

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

yinyiqian1
Copy link

@yinyiqian1 yinyiqian1 commented Oct 1, 2024

the discussion link: #212
the rippled PR link: XRPLF/rippled#5142

* Modify AMMClawback spec by adding tfClawTwoAssets flag

* Update XLS-0074d-amm-clawback/README.md

---------

Co-authored-by: Shawn Xie <[email protected]>
#### 2.3.3. AMMClawback transaction examples

##### 2.3.3.1 Only one token is issued by the issuer
Assue we have an AMM pool consisting two tokens FOO and Bar. And the proportion of FOO and BAR is 1:2. And the issuer `rPdYxU9dNkbzC5Y2h4jLbVJ3rMRrk7WVRL` only issues FOO, BAR is issued by some other account.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Assue -> Assume.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

- `tfClawTwoAssets` can not be set because BAR is not issued by the issuer.

##### 2.3.3.2 Both tokens are issued by the same issuer
Assue we have an AMM pool consisting two tokens FOO and Bar. And the proportion of FOO and BAR is 1:2. And the issuer `rPdYxU9dNkbzC5Y2h4jLbVJ3rMRrk7WVRL` issues both FOO and BAR.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Assue -> Assume.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants