Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug with the the explorer not scrollable #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MoritzGruber
Copy link

@MoritzGruber MoritzGruber commented Sep 18, 2021

Hi XKojiMedia,
thanks for the amazing work on Altair!
This MR is a bug fix with the the explorer not being scrollable if there are more queries than one screen size can fit

Current Behaviour:
The explorer is not scrollable in the right container if there are more queries to show than one screen size can fit.

Expected Behaviour:
The explorer is scrollable in the right container if there are more queries to show than one screen size can fit.

Bug:
https://ibb.co/fFQHsxM
Screenshot 2021-09-18 at 14 13 03

Fix:
https://ibb.co/4P8C2
Screenshot 2021-09-18 at 14 12 04
wL

fix bug with the the explorer not scrollable if there are more queries than one screen size can fit 

Bug:
https://ibb.co/fFQHsxM

Fix:
https://ibb.co/4P8C2wL
@@ -1,6 +1,8 @@
.graphiql-explorer-root {
font-size: var(--body-font-size) !important;
font-family: var(--editor-font-family) !important;
overflow: auto !important;
height: calc(100vh - 60px);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't height of 100% work?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it would not - feel free to give it a try

If you would use 100% this is would be the same as 100vh in this case. So the Top tabs (the 60px) would be too much with 100% and you would end up having two scrollbars 😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants