Cache hit chance when sorting the list of potential targets in tactical and ensure the sorted order matches the order of TAB-cycling #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iridar
force-pushed
the
1233-cache-enemy-sort
branch
from
4051dd6
to
673aa72
Compare
Iridar
changed the title
…ets matches the displayed order of target icons
Iridar
force-pushed
the
1233-cache-enemy-sort
branch
from
673aa72
to
35a2259
Compare
|
Tested in lab conditions, tutorial, and first mission afterwards. Seems to work fine. |
|
This needs testing with various targetable interactive objects, such as explosive barrels and psi nodes on the Sabotage Psi Emitter mission. Make sure the order of displayed icons matches the order of clicking on the icon or using an ability to enter targeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1233
Alternative implementation of #1234
Differences: moved the sorting into a separate function, added some code to fix the "bug" where the order of TAB-cycling through targets does not always the match the order of displayed target icons for targets that have the same hit chance.
I separated them into two commits so that the TAB-cycling functionality is easier to see during the review.
I added HL-Docs for this issue as if it's a bugfix, not sure how correct is that, but I figured there's nothing about this change that needs to be mod-dev facing, as it's mostly an optimization change.