Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pickpoint API URL #812

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

tgilcrest
Copy link
Collaborator

Overview

An issue with the geocoding was reported by users in Mumbai. I was looking at the failed requests to get a sense of how involved this fix might be. I realized the URL in the pickpoint docs was different, so when I updated that and tested in Postman it worked perfectly. So putting up the change here in hopes it will just work.

Checklist

  • PR has a descriptive enough title to be useful in changelogs
  • PR is targeting the develop branch (unless this is a release)

Demo

Here's the same request we are making in the app (https://pickpoint.io/api/v1/forward?):
image

Here's the request with the URL updated (https://api.pickpoint.io/v1/forward?):
image

Notes

We haven't touched this code in 4 years, so I assume it's a change that Pickpoint made. I looked in our inbox and didn't see any notifications that this was changing, so I'm kind of puzzled how they would just go and make a change like that.

Testing Instructions

  • Load up the environment
  • Create an incident
  • Start typing in the Location box and pickpoint should make a request to search

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant