Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smoke tests #56

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Add smoke tests #56

wants to merge 2 commits into from

Conversation

tellyworth
Copy link
Contributor

This adds some basic smoke tests (mis)using phpunit.

The tests will fetch http://localhost:8888 and http://localhost:8888/download/ and run a few basic sanity tests on the HTML output.

Sample output:

% yarn test
yarn run v1.22.18
$ ./vendor/phpunit/phpunit/phpunit tests/phpunit
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

........SS                                                        10 / 10 (100%)

Time: 6.05 seconds, Memory: 4.00 MB

OK, but incomplete, skipped, or risky tests!
Tests: 10, Assertions: 12, Skipped: 2.
✨  Done in 6.17s.

How to test the changes in this Pull Request:

  1. yarn test

@tellyworth tellyworth added the [Component] Tools Build tools, packages, etc label Aug 8, 2022
@ryelle
Copy link
Contributor

ryelle commented Aug 11, 2022

Is this meant to be a framework for other tests? It works for me, but I'm not totally sure why we need it.

@tellyworth
Copy link
Contributor Author

Intended as a starting point, and potentially a framework for more tests if it's useful.

It probably isn't useful though if there's not a good way to incorporate it into the sync/deploy process. Probably belongs in next iteration / pending discussion, to figure out if it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Tools Build tools, packages, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants