Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating translated patterns/templates, use esc_attr_e() for attributes #392

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

dd32
Copy link
Member

@dd32 dd32 commented Feb 22, 2024

Replaces a TODO in the code with replacing attributes with an escaped variant.

This isn't the cleanest way to achieve the result, but it is the smallest possible code change.

It might look like href should have esc_url( __( .. ) ) but that complicates it with minimal benefit.

Draft as I don't have time to follow up on it completely right now.
Feel free to take over.

How to test the changes in this Pull Request:

  1. yarn build:patterns
  2. Test.

@dd32 dd32 added [Component] Tools Build tools, packages, etc priority: low This should happen sometime, but other things are more important [Type] Enhancement New feature or request labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Tools Build tools, packages, etc priority: low This should happen sometime, but other things are more important [Type] Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant