Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to camptix-invoices plugin #965

Open
wants to merge 15 commits into
base: production
Choose a base branch
from

Conversation

timiwahalahti
Copy link
Collaborator

@timiwahalahti timiwahalahti commented Jul 20, 2023

As the Community Team agreed to activate the Camptix Invoices plugin for all new WordCamps by default, I started looking at the plugin's codebase to identify if there are things that need some tweaks to make it work without organisers needing to update settings.

In this PR:

  • Enable invoices by default
  • Enable VAT field by default
  • Use site date format as default in the invoice
  • If all enabled payment methods use allowed predefined WPCS accounts, use WPCS address in the invoice. In other cases, default to the site name and ask organisers to update the setting.
  • Makes address and VAT fields optional
  • Prevents the email being sent if no attachment

Fixes #928, #255, #640
See #971

Props @javiercasares, @harmonyromo, @ciudadanoB, @dd32

Things identified that need work:

  • Handle invoice sender details when WordCamps is not using WPCS to run money
  • Possibly enable VAT field by default
  • Activate invoices by default (the setting)
  • Add plugin to list of network activated ones
  • Make VAT field optional
  • Network activate the plugin

Screenshots

Camptix invoices settings with new defaults.
image

Paypal payment method enabled with custom and Stripe enabled with WPCS, notice about company address.
image

All payment methods using WPCS, company address field hidden from invoice settings.
image

Invoice fields on tickets page.
image

Invoice PDF.
image

How to test the changes in this Pull Request:

  1. Create new WordCamp site and activate Camptix Invoices
  2. Navigate to Camptix settings, invoices tab -> invoices and VAT should be enabled
  3. Go to payment tab, activate Paypal or Stripe with custom account -> you should see notice about company address
  4. Activate the other payment method with WPCS account -> you should still see the notice
  5. Change the first payment method to use WPCS account -> notice should dissapear
  6. Go buy ticket, request invoice -> invoice should be sent and WPCS address should be in invoice

@timiwahalahti timiwahalahti marked this pull request as draft July 20, 2023 12:47
@renintw renintw added [Priority] High Migrated from Trac [Type] Internationalization Issues related to i18n or handling non-English languages or content and removed [Priority] 2 labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] CampTix Including addons Migrated from Trac [Priority] High [Type] Internationalization Issues related to i18n or handling non-English languages or content
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

“Invoices”, activated by default
2 participants