Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add First Time being a organizer/speaker/sponsor question to CPT #939

Merged

Conversation

renintw
Copy link
Contributor

@renintw renintw commented Jul 12, 2023

See #888

This PR adds First Time being an organizer/speaker/sponsor question to CPT and prepares CPT stub for form automation in order to allow the WordCamp Counts to retrieve the first_time value.

Screenshots

Sponsor
image
Speaker
image
Organizer
image

How to test the changes in this Pull Request:

  1. Go to individual sites.
  2. Go to Sponsors/Organizers/Speakers and click on anyone listed there.
  3. You'll see the meta box questions as the above screenshots show.

Questions

  1. I'm curious if the timing for a volunteer/speaker/sponsor to fill in the first-time volunteer/speaker/sponsor can only be through the initial form that's created on a new website? If a user deletes this initial form, is there another way to retrieve it later?

  2. Is the timing to fill in the first-time organizer only through the organizer's block editor page side panel? Is there a need to prepare an organizer stub for form automation?

@renintw renintw self-assigned this Jul 12, 2023
@renintw renintw force-pushed the feature/first-time-checkbox-for-speakers-sponsors-organizers branch 2 times, most recently from dc9a1a7 to 5420dd2 Compare July 12, 2023 07:31
Copy link
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few suggestions, but I think this is pretty good overall and heading in the right direction 👍🏻

@renintw renintw changed the title Organizers: Add First Time being a organizer question to CPT Add First Time being a organizer/speaker/sponsor question to CPT Jul 20, 2023
@renintw renintw force-pushed the feature/first-time-checkbox-for-speakers-sponsors-organizers branch from 70b3fb6 to 8ededd5 Compare July 20, 2023 10:31
@renintw renintw force-pushed the feature/first-time-checkbox-for-speakers-sponsors-organizers branch from 7d1d42e to fbde988 Compare July 25, 2023 04:13
@renintw renintw marked this pull request as ready for review July 25, 2023 18:13
@renintw renintw added this to the Pilot Events: MVP milestone Jul 25, 2023
@renintw renintw force-pushed the feature/first-time-checkbox-for-speakers-sponsors-organizers branch from 4c2dca5 to 3f85cc7 Compare July 26, 2023 07:26
@renintw renintw merged commit 76de29c into production Jul 26, 2023
3 checks passed
@renintw renintw deleted the feature/first-time-checkbox-for-speakers-sponsors-organizers branch July 26, 2023 08:44
@renintw
Copy link
Contributor Author

renintw commented Jul 26, 2023

@iandunn Much appreciated to you answering all my questions and I've learned a lot. I've made some commit updates based on your last round of feedback and went ahead to merge the PR 👍
But you might have missed the two questions that I added to the PR description later. They won't affect this PR, but they are extended questions that I thought of from this issue. It'd be nice if you could shed some light on them.

@renintw renintw linked an issue Jul 26, 2023 that may be closed by this pull request
10 tasks
@iandunn
Copy link
Member

iandunn commented Jul 26, 2023

Great job 🎉

I'm curious if the timing for a volunteer/speaker/sponsor to fill in the first-time volunteer/speaker/sponsor can only be through the initial form that's created on a new website? If a user deletes this initial form, is there another way to retrieve it later?

There isn't an automated way to recreate the form, they'd need to manually create the form with the same questions and add the wcfd-key custom field. That's why we have the warning that modifying the form can break the automation.

The post types will still have the questions and data, though, so manually created posts could still collect the data.

Is the timing to fill in the first-time organizer only through the organizer's block editor page side panel? Is there a need to prepare an organizer stub for form automation?

It's the same as the other post types, except that we don't have the automation set up yet, and we don't have a Call for Organizers post. That's probably less needed than the others, since organizers are often chosen before the site is created, but there could be some camps that would benefit from it. It's never been a high priority though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Measure first-time participation
2 participants