-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add First Time being a organizer/speaker/sponsor question to CPT #939
Add First Time being a organizer/speaker/sponsor question to CPT #939
Conversation
dc9a1a7
to
5420dd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few suggestions, but I think this is pretty good overall and heading in the right direction 👍🏻
public_html/wp-content/plugins/multi-event-sponsors/classes/mes-sponsor.php
Outdated
Show resolved
Hide resolved
public_html/wp-content/plugins/wc-post-types/views/sponsors/metabox-sponsor-info.php
Outdated
Show resolved
Hide resolved
public_html/wp-content/plugins/wc-post-types/views/sponsors/metabox-sponsor-info.php
Outdated
Show resolved
Hide resolved
public_html/wp-content/plugins/wordcamp-forms-to-drafts/wordcamp-forms-to-drafts.php
Show resolved
Hide resolved
public_html/wp-content/plugins/wcpt/stubs/post/call-for-speakers.php
Outdated
Show resolved
Hide resolved
public_html/wp-content/plugins/wcpt/stubs/post/call-for-sponsors.php
Outdated
Show resolved
Hide resolved
70b3fb6
to
8ededd5
Compare
7d1d42e
to
fbde988
Compare
…th one of the known values.
4c2dca5
to
3f85cc7
Compare
@iandunn Much appreciated to you answering all my questions and I've learned a lot. I've made some commit updates based on your last round of feedback and went ahead to merge the PR 👍 |
Great job 🎉
There isn't an automated way to recreate the form, they'd need to manually create the form with the same questions and add the The post types will still have the questions and data, though, so manually created posts could still collect the data.
It's the same as the other post types, except that we don't have the automation set up yet, and we don't have a Call for Organizers post. That's probably less needed than the others, since organizers are often chosen before the site is created, but there could be some camps that would benefit from it. It's never been a high priority though. |
See #888
This PR adds First Time being an organizer/speaker/sponsor question to CPT and prepares CPT stub for form automation in order to allow the WordCamp Counts to retrieve the first_time value.
Screenshots
Sponsor
Speaker
Organizer
How to test the changes in this Pull Request:
Questions
I'm curious if the timing for a volunteer/speaker/sponsor to fill in the first-time volunteer/speaker/sponsor can only be through the initial form that's created on a new website? If a user deletes this initial form, is there another way to retrieve it later?
Is the timing to fill in the first-time organizer only through the organizer's block editor page side panel? Is there a need to prepare an organizer stub for form automation?