Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove top and bottom margin 0 on full width patterns #374

Open
wants to merge 12 commits into
base: trunk
Choose a base branch
from

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Sep 19, 2024

Description

Fixes #328

This PR removes the margin top/bottom set to zero for full-width patterns.
It also updates the landing pages to be contained by a group with a block gap of zero.

Bonus:

  • Add description to testimonials patterns.
  • Indent several patterns.

Screenshots

N/A

Testing Instructions

  1. Create a page.
  2. Add the following patterns
    • Banner with book description
    • Banner with description and images grid
    • Clients section
    • Centered link and social links
    • Contact: Info and locations
    • Cover with big heading
    • Call to action with book links
    • Call to action with locations
    • Pricing two columns
    • Events – List with Call to Action
    • Events three columns with event images and titles
    • Grid with videos
    • Heading and paragraph with image on the right
    • Hero Centered Heading
    • Hero podcast
    • Link in bio with tight margins
    • Newsletter Sign Up
    • Poster-like section
    • Services - Subscriber only section
    • Services - Three-column boxed pricing table
    • Services - Three Columns
    • Review with large image on right
    • Three column layout with 6 testimonials
    • Two columns with avatar
    • FAQs
    • Two Headings and a List
  3. Confirm that these patterns no longer have a margin top/bottom set to zero.

Copy link

github-actions bot commented Sep 19, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

github-actions bot commented Sep 19, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: beafialho <[email protected]>
Co-authored-by: maneshtimilsina <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanfra juanfra added the [Type] Enhancement A suggestion for improvement. label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove top and bottom margin 0 on full width patterns
1 participant