Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update text-wrap style. Closes #346 #349

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Update text-wrap style. Closes #346 #349

wants to merge 3 commits into from

Conversation

bobmatyas
Copy link
Contributor

Description

Per #346, this adds the text-wrap style to deal with widows and orphans.

Screenshots

Before Example:

before-text-wrap

After Example:

after-text-wrap

Testing Instructions

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: bobmatyas <[email protected]>
Co-authored-by: ryelle <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@luminuu luminuu linked an issue Sep 17, 2024 that may be closed by this pull request
Enhancement to reduce widows and orphans in the theme #346
Open
ryelle
ryelle reviewed Sep 17, 2024
View reviewed changes
style.css Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

carolinan
carolinan requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please remove changes that are unrelated to the text-wrap.

@bobmatyas
Copy link
Contributor Author

@carolinan I think I was able to remove the extraneous commits. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryelle ryelle Awaiting requested review from ryelle

@carolinan carolinan Awaiting requested review from carolinan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement to reduce widows and orphans in the theme
3 participants
@bobmatyas @ryelle @carolinan