-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Noon, Evening and Afternoon variations #333
base: trunk
Are you sure you want to change the base?
Conversation
The buttons especially in noon are still problematic, with some background colors both the default and outline buttons look like plain text. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
From the screenshot, it looks like section 3 and 5 in afternoon is the same? |
The button outlines in styles 2 and 4 don't look good in any of the variations. Is there something we can do about it? |
I'll try to add a different color in Afternoon. |
I think this will be the most difficult part about adding the variations. In styles/blocks/section-2.json the button is set to contrast and base:
Then in noon (as an example), section-2 can be updated like this:
|
(the outline button can not be changed the same way) |
Description
Adds combined variations remaining in #193.
I had to change the hues and order of some color palettes for the section styles to work. I'll update the Figma with the new colors.
Screenshots
Evening:
Noon:
Afternoon: