Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Noon, Evening and Afternoon variations #333

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

beafialho
Copy link
Contributor

@beafialho beafialho commented Sep 16, 2024

Description

Adds combined variations remaining in #193.

I had to change the hues and order of some color palettes for the section styles to work. I'll update the Figma with the new colors.

Screenshots

Evening:

Captura de ecrã 2024-09-16, às 16 48 12

Noon:

Captura de ecrã 2024-09-16, às 16 58 21

Afternoon:

Captura de ecrã 2024-09-16, às 16 59 15

@carolinan
Copy link
Contributor

The buttons especially in noon are still problematic, with some background colors both the default and outline buttons look like plain text.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: beafialho <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan
Copy link
Contributor

From the screenshot, it looks like section 3 and 5 in afternoon is the same?

@beafialho
Copy link
Contributor Author

The button outlines in styles 2 and 4 don't look good in any of the variations. Is there something we can do about it?

@beafialho
Copy link
Contributor Author

I'll try to add a different color in Afternoon.

@carolinan
Copy link
Contributor

The button outlines in styles 2 and 4 don't look good in any of the variations. Is there something we can do about it?

I think this will be the most difficult part about adding the variations.

In styles/blocks/section-2.json the button is set to contrast and base:


"elements": {
			"button": {
				"color": {
					"background": "var:preset|color|contrast",
					"text": "var:preset|color|base"
				}
			}

Then in noon (as an example), section-2 can be updated like this:

"variations": {
		"section-2": {
				"elements": {
					"button": {
						"color": {
							"background": "anything",
							"text": "anything"
						}
					}
...

@carolinan
Copy link
Contributor

(the outline button can not be changed the same way)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants