Fix creating a table with AUTOINCREMENT and ON UPDATE followed by PRIMARY KEY
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MARY KEY This reverts e59eff8. The fix was wrong. When spotting it, I misunderstood that the first token was already consumed. Without the fix, the new test fails with: Cannot combine AUTOINCREMENT and multiple primary keys in SQLite. This is because we've consumed one extra token (,), and the PRIMARY KEY then gets assigned to the created_at column as well.
13 tasks
brandonpayton
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts e59eff8. The fix was wrong. When spotting it, I misunderstood that the first token was already consumed.
Without the fix, the new test fails with:
This is because we've consumed one extra token (
,), and thePRIMARY KEYthen gets assigned to thecreated_atcolumn as well.