v2.1.13 #143
Merged
v2.1.13 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses an issue where the output of `show create table` is incorrect when the table has a `NULL` column without a default value. Here is an example: ```sql -- Original MySQL query CREATE TABLE `wp_usermeta` ( `umeta_id` bigint(20) unsigned NOT NULL auto_increment, `user_id` bigint(20) unsigned NOT NULL default '0', `meta_key` varchar(255) default NULL, `meta_value` longtext, PRIMARY KEY (`umeta_id`), KEY `user_id` (`user_id`), KEY `meta_key` (`meta_key`(191)) ) -- Output by `SHOW CREATE TABLE` via SQLite plugin CREATE TABLE `wp_usermeta` ( `umeta_id` bigint(20) unsigned NOT NULL AUTO_INCREMENT, `user_id` bigint(20) unsigned NOT NULL DEFAULT '0', `meta_key` varchar(255) DEFAULT NULL, `meta_value` longtext DEFAULT , -- Default value missing PRIMARY KEY (`umeta_id`), KEY `meta_key` (`meta_key`), KEY `user_id` (`user_id`) ); -- After this fix CREATE TABLE `wp_usermeta` ( `umeta_id` bigint(20) unsigned NOT NULL AUTO_INCREMENT, `user_id` bigint(20) unsigned NOT NULL DEFAULT '0', `meta_key` varchar(255) DEFAULT NULL, `meta_value` longtext, PRIMARY KEY (`umeta_id`), KEY `meta_key` (`meta_key`), KEY `user_id` (`user_id`) ); ```
This PR addresses an issue where the ALTER TABLE CHANGE with skipped COLUMNS keyword was ignored. We supporter query ```sql -- Processed correctly ALTER TABLE _tmp_table CHANGE COLUMN name firstname varchar(50) NOT NULL default 'mark'; -- Was ignored ALTER TABLE _tmp_table CHANGE name firstname varchar(50) NOT NULL default 'mark'; ``` This PR fixes the issue by adding support for optional COLUMN in the ALTER TABLE CHANGE query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.1.13