-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the analytics events for relevancy #5108
base: main
Are you sure you want to change the base?
Conversation
a3df6ac
to
b316ffe
Compare
Latest k6 run output1
Footnotes
|
1b0d0ca
to
7533d13
Compare
d8bc635
to
378da7c
Compare
Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR: @krysal Excluding weekend1 days, this PR was ready for review 4 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)2. @obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
@obulat, I'll put this in draft while the tests are resolved. |
378da7c
to
0c09852
Compare
Playwright failure test results: https://github.com/WordPress/openverse/actions/runs/11718843873 It looks like some of the Playwright tests failed. If you made changes to the frontend UI without updating snapshots, this might be the cause. You can download zipped patches containing the updated snapshots alongside a general trace of the tests under the "Artifacts" section in the above page. They're named in the form You can read more on how to use these artifacts in the docs. If the test is flaky, follow the flaky test triage procedure. |
Fixes
Fixes #5005 by @zackkrida
Fixes #5107 by @obulat
Description
This PR updates the analytics events so that we can analyze results for relevancy for their search queries.
From the single result page events (
COPY_ATTRIBUTION
,GET_MEDIA
,RIGHT_CLICK
), and for selecting the result (SELECT_SEARCH_RESULT
), we can now see the search query and the position of the current result in the list of results.Some of the event data were refactored to simplify the code.
Testing Instructions
Run the app using
ov just frontend/run dev
Run a search and select a search result. You should see
SELECT_SEARCH_RESULT
event with query and position logged in the console.If you click on "Copy button", or right-click on the image, you should see the new properties (position and query) for the analytics events in the console.
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin