Fix: Button Replace remaining 40px default size violations [Block Directory] #65467
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| @@ -101,8 +101,7 @@ const ModifiedWarning = ( { originalBlock, ...props } ) => { | |||
| ); | |||
| actions.push( | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
| @@ -22,8 +22,7 @@ export default function InstallButton( { attributes, block, clientId } ) { | |||
|
|
|||
| return ( | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
|
I have not changed the Here is the screenshot of design break after adding the
|
What?
This would fix in that in subtask
block-directory.Why?
To make the consistent button across Gutenberg, and we would have a lint rule added once fixed, all the button usage.
How?
Change from
__next40pxDefaultSize={ false }to__next40pxDefaultSizeon component.Testing Instructions
Testing steps and screenshots are added below.