Add __nextHasNoMarginBottom to BaseControl-based components #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
commented
Sep 22, 2024
|
|
||
| <Text variant="muted"> | ||
| { __( | ||
| help={ __( |
There was a problem hiding this comment.
This change is a small improvement. It prevents a large space from appearing between the input field and the help text.
| Before | After |
|---|---|
 |
 |
madhusudhand
approved these changes
Sep 23, 2024
|
@madhusudhand Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #728
As presented in the following issue, BaseControl-based components are planned to have margin-free style as the default behavior:
WordPress/gutenberg#64408
For this future effort, and to suppress browser warnings, we need to add the
__nextHasNoMarginBottomprop.By adding
__nextHasNoMarginBottom, the bottom margin of the BaseControl-based components will be removed, making the stacked layout a bit cramped. To prevent this, I increased the value of thespacingprop of theVStackcomponent.There should be very little visual change caused by this PR.