Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(node)!: update 16.14 -> 18.16 #37

Merged
merged 4 commits into from
Sep 25, 2024
Merged

chore(node)!: update 16.14 -> 18.16 #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7015eb0
chore: update node 16.14 -> 18.16 (latest LTS)
lediur May 10, 2023
74d1276
chore(pkgs): update hot-shots 8.3.0 -> 10.0.0 (fix unix-dgram compat)
lediur May 10, 2023
e02b23a
fix: update css-loader (fix postcss compat)
ajohn25 Aug 6, 2024
3204d1d
Merge branch 'main' into chore/update-node-18
ajohn25 Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
strategy:
matrix:
node-version:
- 16.14.0-buster
- 18.16.0-buster

container:
image: node:${{ matrix.node-version }}
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.14
18.16
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
### Dependency Cacher
### -------------------------
FROM endeveit/docker-jq:latest as deps

Check warning on line 3 in Dockerfile

View workflow job for this annotation

GitHub Actions / Hadolint 

Using latest is prone to errors if the image will ever update. Pin the version explicitly to a release tag

# To prevent cache invalidation from changes in fields other than dependencies
# https://stackoverflow.com/a/59606373
Expand All @@ -10,7 +10,7 @@

### Fat Build
### -------------------------
FROM node:16.14.0 AS builder
FROM node:18.16.0 AS builder

WORKDIR /usr/Spoke

Expand All @@ -36,14 +36,14 @@

### Slim Deploy
### -------------------------
FROM node:16.14.0
FROM node:18.16.0

WORKDIR /usr/Spoke

# Install and cache production dependencies
COPY --from=deps /tmp/deps.json ./package.json
COPY yarn.lock ./
RUN yarn install --production

Check notice on line 46 in Dockerfile

View workflow job for this annotation

GitHub Actions / Hadolint 

`yarn cache clean` missing after `yarn install` was run.

# Copy only the built source
COPY --from=builder /usr/Spoke/build ./build
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ that goal. See [`HOWTO_migrate-from-moveon-main.md`](./docs/HOWTO_migrate-from-m

Runtimes and package managers:

- Node (^16.14)
- Node (^18.16)
- Yarn (>= 1.19.1)

External services:
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"engines": {
"npm": "please-use-yarn",
"yarn": ">= 1.19.1",
"node": "^16.14.0"
"node": "^18.16.0"
},
"scripts": {
"preinstall": "node -e \"if(process.env.npm_execpath.indexOf('yarn') === -1) throw new Error('spoke must be installed with Yarn: https://yarnpkg.com/')\"",
Expand Down Expand Up @@ -107,7 +107,7 @@
"connect-pg-simple": "^7.0.0",
"cors": "^2.8.5",
"cryptr": "^6.0.3",
"css-loader": "^5.0.1",
"css-loader": "^7.1.2",
"dataloader": "^1.2.0",
"dotenv": "^8.0.0",
"dotenv-cli": "^4.1.1",
Expand All @@ -129,7 +129,7 @@
"graphql-type-json": "^0.3.2",
"graphql-upload": "^13.0.0",
"history": "^5.0.0",
"hot-shots": "^8.3.0",
"hot-shots": "^10.0.0",
"humps": "^1.1.0",
"iconv-lite": "^0.5.1",
"immer": "^8.0.1",
Expand Down
Loading
Loading