work around aes_string() deprecation

DESCRIPTION

@@ -26,6 +26,7 @@ Imports:
     cdata (>= 1.2.0),
     rqdatatable (>= 1.3.1),
     rquery (>= 1.4.9),
+    rlang,
     utils,
     grid,
     gridExtra,
@@ -39,5 +40,5 @@ Suggests:
     plotly,
     hexbin, 
     tinytest
-RoxygenNote: 7.1.1
+RoxygenNote: 7.2.3
 ByteCompile: true

NAMESPACE

@@ -44,6 +44,7 @@ export(ThresholdPlot)
 export(plot_Keras_fit_trajectory)
 export(plot_fit_trajectory)
 export(plotlyROC)
+export(simulate_aes_string)
 import(rqdatatable)
 import(rquery)
 import(wrapr)

R/ScatterBoxPlot.R

@@ -30,7 +30,7 @@
 #' WVPlots::ScatterBoxPlot(frm2, "label", "meas", pt_alpha=0.2, title="Example Scatter/Box plot")
 #'
 #' @export
-ScatterBoxPlot = function(frm, xvar, yvar, title, ...,
+ScatterBoxPlot <- function(frm, xvar, yvar, title, ...,
                           pt_alpha=0.3,
                           pt_color='black',
                           box_color='black',
@@ -45,7 +45,7 @@ ScatterBoxPlot = function(frm, xvar, yvar, title, ...,
     stop(paste(xvar, "should be discrete (factor, character, integer, or logical)"))
   }
 
-  ggplot2::ggplot(frm, ggplot2::aes_string(x=xvar, y=yvar, group=xvar)) +
+  ggplot2::ggplot(data=frm, mapping=ggplot2::aes(!!!simulate_aes_string(x=xvar, y=yvar, group=xvar))) +
     ggplot2::geom_boxplot(outlier.size=0, color=box_color, fill=box_fill) +
     ggplot2::geom_point(color=pt_color, alpha=pt_alpha, position=ggplot2::position_jitter(width=0.1,height=0)) +
     ggplot2::ggtitle(title)

R/SimulateAESString.R

@@ -0,0 +1,37 @@
+
+
+#' Simulate the needlessly deprecated \code{ggplot2::aes_string()}.
+#'
+#' Use to allow (needlessly) replacing code of the form \code{ggplot2::aes_string(...)}
+#' with code of the form \code{ggplot2::aes(!!!simulate_aes_string(...))}.
+#' Purpose is to get out of the way of the deprecation and possible future removal of \code{ggplot2::aes_string()}.
+#' This will itself break when \code{rlang} again chantes its API and deprecates the affordances used.
+#' Inspired by the research of \url{https://stackoverflow.com/a/74424353/6901725}.
+#'
+#'
+#' @param ... named string arguments to turn into symbols using `rlang::data_sym()`.
+#' @return some rlang NSE that simulates values at great complexity (but needed for newer ggplot2()).
+#'
+#' @examples
+#'
+#' d <- data.frame(x = c(1, 2, 3), y = c(4, 5, 6))
+#' xvar <- 'x'  # the idea is, this is passed in and not known at coding time
+#' yvar <- 'y'
+#' # what we want:
+#' #  ggplot2::ggplot(data = d, mapping = ggplot2::aes_string(x = xvar, y = yvar)) + ggplot2::geom_point()
+#' # The required "tidy evaluation ideoms[sic] with `aes()`".
+#' ggplot2::ggplot(data = d, mapping = ggplot2::aes(!!!simulate_aes_string(x = xvar, y = yvar))) + ggplot2::geom_point()
+#'
+#' @export
+simulate_aes_string <- function(...) {
+  # replace the needlessly deprecated aes_string
+  # from:
+  #  https://stackoverflow.com/a/74424353/6901725
+  args <- list(...)
+  for (v in args) {
+    if (is.character(v)) {
+      stopifnot(length(v) == 1)
+    }
+  }
+  lapply(args, function(x) {if (is.character(x)) rlang::data_sym(x) else x})
+}