-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options for oidc-client-ts
#570
Conversation
can someone accept this pull? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can / should cover this with unit tests to make sure it doesn't break anything. Also need to make sure we test this against Keycloak so nothing breaks.
@alexfdezsauco , what do you think?
So, approved with recommendations. |
Thanks for the great update on the readme. If you can add the explanation of the new features in the readme (e.g. when are the options needed, how should they be used), then this PR is perfect and can be merged (and we will release ASAP). |
sure. i'll update it soon |
@GeertvanHorrik thank you for your patience. last week i was sick (again) and finally got some time today to make some progress. please take a look when convenient. cc @alexfdezsauco |
@alexfdezsauco @GeertvanHorrik Hi guys, is there anything I should do to move forward? |
@gao-sun No worries about the delay, hopefully you feel better now. The PR is great, thank you. I will release this one and also look into the updated oidc client (v3 was released yesterday). |
thank you! i'm feeling all good now. look forward to the release! |
You can test it in beta. If it works, we'll release as stable: https://www.nuget.org/packages/Blorc.OpenIdConnect/1.9.0-beta0001 |
@GeertvanHorrik just tested locally, i can confirm the new config options work as expected. |
Excellent, will release as stable now, ETA 10 - 15 minutes. |
Description of Change
Add three options for the underlying library 'oidc-client-ts':
resource
,extraQueryParams
,extraTokenParams
.Issues Resolved
API Changes
OidcProviderOptions
now supports more options.Behavioral Changes
Authentication and token requests will add parameters according to the new options, if any.
Testing Procedure
Tested in Google Chrome Version 120.0.6099.109 (Official Build) (arm64)
src/Blorc.OpenIdConnect.DemoApp/Program.cs
.dotnet watch
to start the dev server, the click the "Login" button.Auth request sample
Token request sample
PR Checklist