Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for oidc-client-ts #570

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Conversation

gao-sun
Copy link
Contributor

@gao-sun gao-sun commented Dec 25, 2023

Description of Change

Add three options for the underlying library 'oidc-client-ts': resource, extraQueryParams, extraTokenParams.

Issues Resolved

API Changes

OidcProviderOptions now supports more options.

Behavioral Changes

Authentication and token requests will add parameters according to the new options, if any.

Testing Procedure

Tested in Google Chrome Version 120.0.6099.109 (Official Build) (arm64)

  1. Update options per src/Blorc.OpenIdConnect.DemoApp/Program.cs.
  2. Use dotnet watch to start the dev server, the click the "Login" button.
  3. The app will initiate an authentication request with the extra params.
  4. In the following token request, extra token params will be carried.
Auth request sample image
Token request sample image

PR Checklist

  • I have included examples or tests
  • I have updated the change log (didn't find)
  • I am listed in the CONTRIBUTORS file (didn't find)
  • Changes adhere to coding standard
  • I checked the licenses of Third Party software and discussed new dependencies with at least 1 other team member (N/A)

@CLAassistant
Copy link

CLAassistant commented Dec 25, 2023

CLA assistant check
All committers have signed the CLA.

@gao-sun gao-sun marked this pull request as ready for review December 25, 2023 11:51
@vitalybrandes
Copy link

can someone accept this pull?

Copy link
Member

@GeertvanHorrik GeertvanHorrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can / should cover this with unit tests to make sure it doesn't break anything. Also need to make sure we test this against Keycloak so nothing breaks.

@alexfdezsauco , what do you think?

@alexfdezsauco
Copy link
Contributor

So, approved with recommendations.

@GeertvanHorrik
Copy link
Member

Thanks for the great update on the readme. If you can add the explanation of the new features in the readme (e.g. when are the options needed, how should they be used), then this PR is perfect and can be merged (and we will release ASAP).

@gao-sun
Copy link
Contributor Author

gao-sun commented Jan 9, 2024

Thanks for the great update on the readme. If you can add the explanation of the new features in the readme (e.g. when are the options needed, how should they be used), then this PR is perfect and can be merged (and we will release ASAP).

sure. i'll update it soon

@gao-sun
Copy link
Contributor Author

gao-sun commented Jan 22, 2024

@GeertvanHorrik thank you for your patience. last week i was sick (again) and finally got some time today to make some progress. please take a look when convenient. cc @alexfdezsauco

@gao-sun
Copy link
Contributor Author

gao-sun commented Jan 31, 2024

@alexfdezsauco @GeertvanHorrik Hi guys, is there anything I should do to move forward?

@GeertvanHorrik
Copy link
Member

@gao-sun No worries about the delay, hopefully you feel better now.

The PR is great, thank you.

I will release this one and also look into the updated oidc client (v3 was released yesterday).

@GeertvanHorrik GeertvanHorrik enabled auto-merge (rebase) January 31, 2024 07:52
@gao-sun
Copy link
Contributor Author

gao-sun commented Jan 31, 2024

@gao-sun No worries about the delay, hopefully you feel better now.

The PR is great, thank you.

I will release this one and also look into the updated oidc client (v3 was released yesterday).

thank you! i'm feeling all good now. look forward to the release!

@GeertvanHorrik GeertvanHorrik merged commit 0cbd250 into WildGums:develop Jan 31, 2024
2 checks passed
@gao-sun gao-sun deleted the patch-1 branch January 31, 2024 07:53
@GeertvanHorrik
Copy link
Member

You can test it in beta. If it works, we'll release as stable:

https://www.nuget.org/packages/Blorc.OpenIdConnect/1.9.0-beta0001

@gao-sun
Copy link
Contributor Author

gao-sun commented Jan 31, 2024

You can test it in beta. If it works, we'll release as stable:

https://www.nuget.org/packages/Blorc.OpenIdConnect/1.9.0-beta0001

@GeertvanHorrik just tested locally, i can confirm the new config options work as expected.

@GeertvanHorrik
Copy link
Member

Excellent, will release as stable now, ETA 10 - 15 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add audience or Resource
5 participants