Commits on Mar 5, 2024

1. PLATFORM-9121 | Do not swallow DB errors in Cargo query …

   Cargo currently swallows all exceptions thrown while it is running
   queries, mainly because it may throw MWExceptions as validation errors
   which should be formatted nicely without breaking the rest of the page.
   However, the queries themselves may fail due to transient database
   issues, and Cargo wraps the resulting DBError exceptions as well without
   much ado. The effect is that these errors never get logged (so we don't
   even know how often this happens), and the error gets cached in parser
   cache and on the CDN, forcing people to check for and periodically purge
   pages with such errors.
   
   Instead, detect and rethrow errors coming from MediaWiki's DBAL so that
   we can track them in our logs, and so that they do not get cached.

   

   mszabo-wikia committed Mar 5, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 3e29ed7
   • Browse repository at this point

   Copy the full SHA

   3e29ed7 View commit details

   Browse the repository at this point in the history