Refactor Texteditor code to ImHex standards. #1891
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no code added or removed. All changes are to make Text editor code look more like the rest of ImHex. - All member variable names that used a convention like in `mFieldVariable` were switched to the common ImHex convention of `m_fieldVariable`. - All member function names that used pascal case were switched to the common ImHex convention of camel case. - All int, unsigned int, unsigned long ... were switched to int32_t, uint32_t, uint64_t,... I used those because TextEditor has no access to the ImHex headers where the types are defined. - Local variable names that were cryptic were given more descriptive ones. - Other changes include a few fixes from cppCheck mostly for variable scope.
|
I tried to merge this locally and found that it is probably not a good idea to do a large refactor when there are lots of prs pending, so I'll draft this for now and wait until there has been a chance to merge the others |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no code added or removed. All changes are to make Text editor code look more like the rest of ImHex.
mFieldVariablewere switched to the common ImHex convention ofm_fieldVariable.