revert local override on no_fdflags_sync_support #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* I couldn't find this in wasmtime repo. I suppose this was a local modification done as a part of WebAssembly#68 * As some implementations have implemented it, it isn't appropriate to assert NOTSUP by default.
|
I think this change is OK given that this is specifically for preview1 (because of the use of wasi crate). I think we should also somehow keep track on the test configuration in test results, I've opened a ticket to discuss this: #93 |
|
Looks good, I'm just wondering whether we should assert the sync flag behaviour at all. The test which uses this is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find this in wasmtime repo. I suppose this was a local modification done as a part of Port more tests from Wasmtime's testsuite #68
As some implementations have implemented it, it isn't appropriate to assert NOTSUP by default.