generated from WebAssembly/wasi-proposal-template
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge the Windowing proposal #5
Open
tareksander
wants to merge
2
commits into
WebAssembly:main
Choose a base branch
from
tareksander:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+267
−127
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
package wasi:webgpu; | ||
|
||
|
||
/// The raw-display interface is designed for when an application has raw access to the full display framebuffer, such as on an embedded device. | ||
interface raw-display { | ||
|
||
enum framebuffer-format { | ||
rgb888, | ||
} | ||
|
||
/// Gets information on the connected displays. | ||
displays: func() -> list<display-info>; | ||
|
||
|
||
record display-info { | ||
/// Internal id for the display, used to connect a grapics-context. | ||
id: u32, | ||
/// An implementation defined identifier of the display. Should be unique. | ||
/// This is so that an application can differentiate e.g. between front and back screens on a device. | ||
name: string, | ||
width: u32, | ||
height: u32, | ||
/// The framebuffer format used. | ||
format: framebuffer-format, | ||
/// Whether the drawing is done in the main framebuffer or in a back buffer. | ||
/// When drawing in a back buffer, blitting is neccessary. | ||
back-buffer: bool, | ||
} | ||
|
||
/// Connects a graphics context to a fisplay. | ||
connect-graphics-context: func(context: borrow<graphics-context>, display-id: u32); | ||
|
||
/// Swaps the front and back buffer of a display, if there is one. | ||
/// TODO: should this invalidate the grapics-context connection? Since the connected buffer changes. | ||
blit: func(display-id: u32); | ||
|
||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How's this different from frame-buffer.wit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a display API, frame-buffer is a graphics API. But you're right, the intended use is to connect a display to a frame-buffer to draw into, primarily for embedded devices. The difference is that frame-buffer is an arbitrary framebuffer, but this maps to hardware displays and their framebuffers. This is just a proof that multiple display APIs are supported, we don't have to actually include it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason we can't use frame-buffer for both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
frame-buffer has no way to specify a screen, or which screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see.
But I'd much rather have one interface for both.
Wanna open a separate issue or PR to discuss?