-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SCDataFrame
class to enable file-based or DataFrame-based data handling (input and output)
#32
Conversation
SCDataFrame
class to enable file-based or DataFrame-based data handlingSCDataFrame
class to enable file-based or DataFrame-based data handling (input and output)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's see what feedback Jenna has when she returns 🌴
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving this PR since I don't see any obvious bugs or issues in the code. I have added a lot of clarifying comments and questions so feel free to address those when possible. This is really cool work!
Co-authored-by: Jenna Tomkinson <[email protected]>
Thanks @gwaybio and @jenna-tomkinson for your thorough reviews! I've addressed your comments and will now merge this in. |
Description
This PR introduces a class called
SCDataFrame
which loosely wraps (but does not extend)pd.DataFrame
to assist with file-based input handling with existing functions incoSMicQC
. This prepares us for CLI development in #14 by allowing filepaths of data to be used as inputs for any function which is currently compatible withpd.DataFrame
.Sidenotes: I reset the
__init__.py
version to be0.0.0
as this is now dynamically versioned on release. I also needed to update some of the existing tests to show that the capabilities haven't changed.Thanks for any feedback you may have! Please don't hesitate to let me know if you have any questions.
Closes #31
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.