refactor: improve migration and model names

WatheqAlshowaiter · Jul 14, 2024 · f47588a · f47588a
1 parent 6338ecb
commit f47588a
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 14 deletions.
diff --git a/...90447_create_parent_test_models_table.php → ...024_07_13_090447_create_fathers_table.php b/...90447_create_parent_test_models_table.php → ...024_07_13_090447_create_fathers_table.php
@@ -8,7 +8,7 @@
 {
     public function up(): void
     {
-        Schema::create('parent_test_models', function (Blueprint $table) {
+        Schema::create('fathers', function (Blueprint $table) {
             $table->id(); // primary key -> ignored
             $table->boolean('active')->default(false); // default => ignored
             $table->string('name'); // required

diff --git a/...eate_another_parent_test_models_table.php → ...024_07_13_093048_create_mothers_table.php b/...eate_another_parent_test_models_table.php → ...024_07_13_093048_create_mothers_table.php
@@ -8,7 +8,7 @@
 {
     public function up(): void
     {
-        Schema::create('another_parent_test_models', function (Blueprint $table) {
+        Schema::create('mothers', function (Blueprint $table) {
             $table->ulid('id')->primary(); // primary key => ignored
             $table->enum('types', ['one', 'two'])->default('one'); // default => ignored
             $table->uuid('uuid'); // required

diff --git a/...100247_create_child_test_models_table.php → ...s/2024_07_13_100247_create_sons_table.php b/...100247_create_child_test_models_table.php → ...s/2024_07_13_100247_create_sons_table.php
@@ -8,10 +8,11 @@
 {
     public function up(): void
     {
-        Schema::create('child_test_models', function (Blueprint $table) {
+        Schema::create('sons', function (Blueprint $table) {
             $table->uuid('id')->primary(); // primary key => ignored
             $table->foreignId('parent_id')->constrained(); // required
-            $table->foreignUlid('another_parent_id')->nullable()->constrained(); // nullable => ignored
+            $table->foreignUlid('mother_id')->nullable()->constrained(); // nullable => ignored
+            $table->foreignId('father_id')->nullable()->constrained(); // nullable => ignored
         });
     }
 

diff --git a/src/Models/ChildTestModel.php → src/Models/Father.php b/src/Models/ChildTestModel.php → src/Models/Father.php
@@ -5,7 +5,7 @@
 use Illuminate\Database\Eloquent\Model;
 use WatheqAlshowaiter\ModelRequiredFields\RequiredFields;
 
-class ChildTestModel extends Model
+class Father extends Model
 {
     use RequiredFields;
 }
diff --git a/src/Models/ParentTestModel.php → src/Models/Mother.php b/src/Models/ParentTestModel.php → src/Models/Mother.php
@@ -5,7 +5,7 @@
 use Illuminate\Database\Eloquent\Model;
 use WatheqAlshowaiter\ModelRequiredFields\RequiredFields;
 
-class ParentTestModel extends Model
+class Mother extends Model
 {
     use RequiredFields;
 }
diff --git a/src/Models/AnotherParentTestModel.php → src/Models/Son.php b/src/Models/AnotherParentTestModel.php → src/Models/Son.php
@@ -5,7 +5,7 @@
 use Illuminate\Database\Eloquent\Model;
 use WatheqAlshowaiter\ModelRequiredFields\RequiredFields;
 
-class AnotherParentTestModel extends Model
+class Son extends Model
 {
     use RequiredFields;
 }
diff --git a/tests/RequiredFieldsTest.php b/tests/RequiredFieldsTest.php
@@ -1,9 +1,9 @@
 <?php
 
 use Illuminate\Foundation\Testing\RefreshDatabase;
-use WatheqAlshowaiter\ModelRequiredFields\Models\AnotherParentTestModel;
-use WatheqAlshowaiter\ModelRequiredFields\Models\ChildTestModel;
-use WatheqAlshowaiter\ModelRequiredFields\Models\ParentTestModel;
+use WatheqAlshowaiter\ModelRequiredFields\Models\Father;
+use WatheqAlshowaiter\ModelRequiredFields\Models\Mother;
+use WatheqAlshowaiter\ModelRequiredFields\Models\Son;
 use WatheqAlshowaiter\ModelRequiredFields\Tests\TestCase;
 
 class RequiredFieldsTest extends TestCase
@@ -15,26 +15,26 @@ public function test_get_required_fields_for_parent_model()
         $this->assertEquals([
             'name',
             'email',
-        ], ParentTestModel::getRequiredFields());
+        ], Father::getRequiredFields());
 
         $this->assertNotEquals([
             'email',
             'name',
-        ], ParentTestModel::getRequiredFields());
+        ], Father::getRequiredFields());
     }
 
     public function test_get_required_fields_for_another_parent_model()
     {
         $this->assertEquals([
             'uuid',
             'ulid',
-        ], AnotherParentTestModel::getRequiredFields());
+        ], Mother::getRequiredFields());
     }
 
     public function test_get_required_fields_for_child_model()
     {
         $this->assertEquals([
             'parent_id',
-        ], ChildTestModel::getRequiredFields());
+        ], Son::getRequiredFields());
     }
 }