Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ldftn and DelegateShim #140

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Add ldftn and DelegateShim #140

merged 5 commits into from
Jun 4, 2024

Conversation

BadRyuner
Copy link
Contributor

  • Adds support for Ldftn OpCode
  • Adds a minimal wrapper for Delegates (.ctor & invoke) + mini test for this thing

Washi1337
Washi1337 requested changes May 28, 2024
View reviewed changes
Copy link
Owner

@Washi1337 Washi1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea and a nice start, however, we need to be super careful here with the implementation details to avoid any inaccuracies that can potentially lead to problems later, or be detected by the emulated process.

src/Platforms/Echo.Platforms.AsmResolver/Emulation/Invocation/DelegateInvoker.cs Outdated Show resolved Hide resolved
src/Platforms/Echo.Platforms.AsmResolver/Emulation/Invocation/DelegateInvoker.cs Outdated Show resolved Hide resolved
src/Platforms/Echo.Platforms.AsmResolver/Emulation/Invocation/DelegateInvoker.cs Outdated Show resolved Hide resolved
src/Platforms/Echo.Platforms.AsmResolver/Emulation/Invocation/DelegateInvoker.cs Outdated Show resolved Hide resolved
src/Platforms/Echo.Platforms.AsmResolver/Emulation/Invocation/DelegateInvoker.cs Outdated Show resolved Hide resolved
src/Platforms/Echo.Platforms.AsmResolver/Emulation/Invocation/DelegateInvoker.cs Outdated Show resolved Hide resolved
src/Platforms/Echo.Platforms.AsmResolver/Emulation/Invocation/DelegateInvoker.cs Outdated Show resolved Hide resolved
src/Platforms/Echo.Platforms.AsmResolver/Emulation/IFunctionMarshaller.cs Outdated Show resolved Hide resolved
src/Platforms/Echo.Platforms.AsmResolver/Emulation/IFunctionMarshaller.cs Outdated Show resolved Hide resolved
src/Platforms/Echo.Platforms.AsmResolver/Emulation/FunctionMarshaller.cs Outdated Show resolved Hide resolved
@Washi1337 Washi1337 added enhancement New feature or request emulation Issue related to the emulation modules of Echo. dotnet-asmresolver Issues related to the .NET back-end powered by AsmResolver labels May 28, 2024
Washi1337
Washi1337 reviewed Jun 3, 2024
View reviewed changes
Copy link
Owner

@Washi1337 Washi1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late reply, and also for not coming with the following comments earlier in the previous review, but I am noticing a few more potential edge cases that we may want to address before merging.

Really appreciate the work you put into it btw!

src/Platforms/Echo.Platforms.AsmResolver/Emulation/Invocation/DelegateInvoker.cs Outdated Show resolved Hide resolved
src/Platforms/Echo.Platforms.AsmResolver/Emulation/CilThread.cs Outdated Show resolved Hide resolved
src/Platforms/Echo.Platforms.AsmResolver/Emulation/Dispatch/Pointers/LdftnHandler.cs Outdated Show resolved Hide resolved
src/Platforms/Echo.Platforms.AsmResolver/Emulation/Invocation/DelegateInvoker.cs Outdated Show resolved Hide resolved
src/Platforms/Echo.Platforms.AsmResolver/Emulation/Invocation/DelegateInvoker.cs Outdated Show resolved Hide resolved
src/Platforms/Echo.Platforms.AsmResolver/Emulation/Invocation/DelegateInvoker.cs Outdated Show resolved Hide resolved
test/Platforms/Echo.Platforms.AsmResolver.Tests/Emulation/CilVirtualMachineTest.cs Show resolved Hide resolved
@Washi1337 Washi1337 merged commit 687c1fe into Washi1337:master Jun 4, 2024
1 check passed
@Washi1337
Copy link
Owner

Thanks a lot!

@BadRyuner BadRyuner deleted the ldftn_delegates branch June 5, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Washi1337 Washi1337 Washi1337 requested changes

Assignees
No one assigned
Labels
dotnet-asmresolver Issues related to the .NET back-end powered by AsmResolver emulation Issue related to the emulation modules of Echo. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BadRyuner @Washi1337