Skip to content

Commit

Permalink
CI: Remove windows-2019-rtools job.
Browse files Browse the repository at this point in the history
  • Loading branch information
WarrenWeckesser committed Sep 21, 2023
1 parent 0c9c694 commit fcdbc5a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 70 deletions.
50 changes: 0 additions & 50 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,56 +113,6 @@ jobs:
run: |
pytest --pyargs ufunclab
windows-2019-rtools:

strategy:
matrix:
# The build fails with numpy versions 1.24.4 and 1.25.2.
# See https://github.com/numpy/numpy/issues/24678
numpy-version: ['1.22.4', '1.23.5']
os: ['windows-2019', 'windows-latest']
fail-fast: false

runs-on: ${{ matrix.os }}

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Setup Python
uses: actions/setup-python@v4
with:
python-version: '3.10'
architecture: 'x64'
cache: 'pip'
cache-dependency-path: 'environment.yml'

- name: Install rtools (mingw-w64)
run: |
choco install rtools -y --no-progress --force --version=4.0.0.20220206
echo "c:\rtools40\ucrt64\bin;" >> $env:GITHUB_PATH
- name: Show gcc version
run: |
gcc --version
- name: Install Python dependencies
run: |
pip install numpy==${{ matrix.numpy-version }} meson ninja meson-python pytest toml
- name: Build
run: |
# Running meson and ninja before pip is only here for debugging
# visibility. Eventually those commands will be removed--all we
# need is pip.
meson setup build
ninja -v -j 1 -C build
pip -v install --no-build-isolation .
- name: Test
run: |
pytest --pyargs ufunclab
windows-msvc:

strategy:
Expand Down
20 changes: 0 additions & 20 deletions meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -12,26 +12,6 @@ project(
cc = meson.get_compiler('c')
cpp = meson.get_compiler('cpp')

# Hack attempt to fix Windows build on CI.
# This necessary to avoid this build failure on Windows (using rtools 4.0 on
# the windows-2019 platform on github/actions)
#
# [54/125] Linking target ufunclab/_next.cp310-win_amd64.pyd
# FAILED: ufunclab/_next.cp310-win_amd64.pyd
# "c++" -o ufunclab/_next.cp310-win_amd64.pyd <...snip...>
# c:/rtools40/ucrt64/bin/../lib/gcc/x86_64-w64-mingw32/10.3.0/../../../
# ../x86_64-w64-mingw32/bin/ld.exe: c:/rtools40/ucrt64/bin/../lib/gcc/
# x86_64-w64-mingw32/10.3.0/../../../../x86_64-w64-mingw32/lib/../lib/
# libmsvcrt.a(deues00259.o):(.text+0x0): multiple definition of `nextafterf';
# c:/rtools40/ucrt64/bin/../lib/gcc/x86_64-w64-mingw32/10.3.0/../../../../
# x86_64-w64-mingw32/lib/../lib/libmingwex.a(lib64_libmingwex_a-nextafterf.o):
# D:/a/rtools-testing/rtools-testing/mingw-w64-crt-git/src/mingw-w64/
# mingw-w64-crt/math/nextafterf.c:10: first defined here
#
if cpp.get_id() != 'clang'
add_project_link_arguments('-Wl,--allow-multiple-definition', language : 'cpp')
endif

# https://mesonbuild.com/Python-module.html
py_mod = import('python')
py3 = py_mod.find_installation(pure: false)
Expand Down

0 comments on commit fcdbc5a

Please sign in to comment.