READY: add fail fast to checkmate stage of CI/CD (#1442)

* feat: add fail fast to `checkmate` stage of CI/CD
Wandalen · Aug 30, 2024 · c903936 · c903936
1 parent 74ae64d
commit c903936
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.github/workflows/standard_rust_push.yml b/.github/workflows/standard_rust_push.yml
@@ -77,7 +77,8 @@ jobs :
         continue-on-error: true
       - name: Check the modules dependencies
         run: cargo +nightly udeps --all-targets --manifest-path ${{ inputs.manifest_path }}
-        continue-on-error: true
+#       This part means that all previous steps will be executed and workflow will not stop if they fail, but not this one.
+        continue-on-error: false
 
 #  release:
 #    if: contains( inputs.commit_message, '+test' ) || contains( inputs.commit_message, 'merge' )
@@ -125,6 +126,9 @@ jobs :
   #        run: cargo miri test --manifest-path ${{ inputs.manifest_path }}
 
   will_test :
+#    This section ensures that `job` `will_test` will only be executed after `checkmate` and if `checkmate` fails, no tests will be run.
+    needs:
+      - checkmate
     if : contains( inputs.commit_message, '+test' ) || inputs.commiter_username == 'web-flow' || startsWith( inputs.commit_message, 'merge' )
     concurrency :
       group : standard_rust_push_${{ inputs.module_name }}_${{ github.ref }}_${{ matrix.os }}

diff --git a/module/move/willbe/template/workflow/standard_rust_push.yml b/module/move/willbe/template/workflow/standard_rust_push.yml
@@ -77,7 +77,8 @@ jobs :
         continue-on-error: true
       - name: Check the modules dependencies
         run: cargo +nightly udeps --all-targets --manifest-path ${{ inputs.manifest_path }}
-        continue-on-error: true
+        #       This part means that all previous steps will be executed and workflow will not stop if they fail, but not this one.
+        continue-on-error: false
 
 #  release:
 #    if: contains( inputs.commit_message, '+test' ) || contains( inputs.commit_message, 'merge' )
@@ -125,6 +126,9 @@ jobs :
   #        run: cargo miri test --manifest-path ${{ inputs.manifest_path }}
 
   will_test :
+#    This section ensures that `job` `will_test` will only be executed after `checkmate` and if `checkmate` fails, no tests will be run.
+    needs :
+      - checkmate
     if : contains( inputs.commit_message, '+test' ) || inputs.commiter_username == 'web-flow' || startsWith( inputs.commit_message, 'merge' )
     concurrency :
       group : standard_rust_push_${{ inputs.module_name }}_${{ github.ref }}_${{ matrix.os }}