Onderwijsmailing #95
Merged
Onderwijsmailing #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Export werkt nog niet, ik geloof dat er in de angular front-end nog e.e.a. aangepast moet worden. |
| @@ -155,6 +155,7 @@ class Meta: | |||
| # Subscriptions | |||
| mail_announcements = models.BooleanField(_('announcements mailing'), default=True) | |||
| mail_company = models.BooleanField(_('company mailing'), default=True) | |||
| mail_educational = models.BooleanField(_('educational mailing'), default=True) | |||
There was a problem hiding this comment.
Zou het niet 'education mailing' moeten zijn? Nu zou je educatieve mails moeten gaan versturen, lijkt me ook wel leerzaam
Als het werkt mag het er wat mij betreft wel in, maar liefst modderen we niet al te lang meer aan met deze export. |
|
Ik geloof dat de export alleen lokaal bij mij problemen geeft, dus wat mij betreft kan 'ie gemerged worden. |
|
Ik kan er mee leven als het stuk gaat. Dus ga mergen. Mocht het stuk gaan moet je het dus maar weer fixen ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Voeg optie 'onderwijsmailing' toe bij mailingvoorkeuren.