[Spec] Handle Ad-Auction-Result response header. #1280
Conversation
qingxinwu
changed the title
|
@brusshamilton Want to review it? |
spec.bs
Outdated
| 1. If |adAuctionResult| contains [=code points=] U+002B (`+`) or U+002F (`/`), return failure. | ||
| 1. Replace every U+2212 (`-`) [=code point=] in |adAuctionResult| with U+002B (`+`). | ||
| 1. Replace every U+005F(`_`) [=code point=] in |adAuctionResult| with U+002F (`/`). | ||
| 1. Let |paddingSize| be <code>|adAuctionResult|'s [=string/length=] % 4</code>. |
There was a problem hiding this comment.
Forgiving base64 decode doesn't require a specific number of = at the end. It's optional.
Also, the math here doesn't seem right. You want to ensure the final length is a multiple of 4. That means you actually want 2 when the remainder is 2, but 1 when the remainder is 3 (and a remainder of 1 should never happen). So something like (4-(len%4))%4, or equivalently, 4*ceil(len/4.0)-len. Better to just remove this part since it's not necessary.
There was a problem hiding this comment.
it requires no more than 2 =. But yeah this is not necessary. Removed, and moved this algorithm's steps inlined to the caller
| @@ -2886,7 +2894,7 @@ a [=list=] of [=interest groups=] |bidIgs|, and a [=list=] of [=bid debug report | |||
| : [=leading bid info/top level seller signals=] | |||
| :: Null | |||
| : [=leading bid info/component seller=] | |||
| :: Null if |topLevelAuctionConfig| is null, otherwise |auctionConfig|'s [=auction config/seller=]. | |||
| :: Null if |topLevelAuctionConfig| is not null, otherwise |auctionConfig|'s [=auction config/seller=]. | |||
There was a problem hiding this comment.
@brusshamilton I think this was a mistake in an earlier PR. Do you agree?
Parses Ad-Auction-Result response header, and verifies a Fetch request to the seller’s origin with "adAuctionHeaders: true" that included an Ad-Auction-Result header with hash of auction config's response_blob (need to do this for component auction config as well, when B&A component auction spec PR is landed).
Preview | Diff