Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genomic_wave.pl sub trainGCModel subsets lrr values differently to method described in paper #88

Open
joshuamschmidt opened this issue Aug 8, 2022 · 1 comment

Comments

@joshuamschmidt
Copy link

I note that this conditional on line 177 of genomic_wave.pl :

if ($data[$i]->[3] > 15 and $data[$i]->[3] < 80 and $data[$i]->[1] > -1 and $data[$i]->[1] < 1)

shouldn't this be:

if ($data[$i]->[3] > 15 and $data[$i]->[3] < 80 and $data[$i]->[1] > -2 and $data[$i]->[1] < 1)

This would be in keeping with method as described in Diskin et. al.:

"To reduce the effect of markers within CNV regions on the regression coefficients, we restricted the analysis to markers with LRR between −2 and 1. "

and also line 186 of the same module:

if ($data[$i]->[3] > 15 and $data[$i]->[3] < 80 and $data[$i]->[1] > -2)

although it is unclear why this line drops the $data[$i]->[1] < 1

@joshuamschmidt
Copy link
Author

Just wondering if there is potential for any clarification on this. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant