Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update db.pp to handle suspicious comments #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akondasif
Copy link

Greetings,

I am a security researcher, who is looking for security smells in Puppet scripts. I found instances
of suspicious comments i.e. comments with content that are indicative of bad practices. If there are keywords such as TODO, HACK, FIXME and bug/issue information is exposed through comments, then such comments should be avoided. According to the Common Weakness Enumeration (CWE) organization Many suspicious comments, such as BUG, HACK, FIXME, LATER, LATER2, TODO, in the code indicate missing security functionality and checking. Others indicate code problems that programmers should fix, such as hard-coded variables, error handling, not using stored procedures, and performance issues. Reff: https://cwe.mitre.org/data/definitions/546.html

I followed the recommendations from CWE and removed such comments. Any feedback is appreciated.

to handle suspicious comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant