Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background color with iOS13 dark theme and wheel style in iOS14. #279

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FlickF
Copy link

@FlickF FlickF commented Nov 14, 2019

Replace the view's background color with system default background color of the chosen iOS theme (dark & light).
Removed some unnecessary background color definitions (hardcoded to white).

This pull request will fix issue #274.

IMG_9C46F7C5904A-1
IMG_BD3443D6ECBD-1

AlexHaumer pushed a commit to AlexHaumer/cordova-plugin-datepicker that referenced this pull request Jun 10, 2020
@FlickF FlickF changed the title Fix background color with iOS13 dark theme. Fix background color with iOS13 dark theme and wheel style in iOS14. Sep 24, 2020
@FlickF
Copy link
Author

FlickF commented Sep 24, 2020

Compiling this plugin with Xcode 12 will break the wheel selection.

Apple added with iOS 13.4 a new property called "preferredDatePickerStyle".
Setting this to "UIDatePickerStyleWheels" will restore the origin functionality.

datepicker_ios14_broken
datepicker_ios14_fixed

@marioshtika
Copy link

@VitaliiBlagodir is this pull request going to be merged?
It looks like it's a simple solution that fixes a big issue.

Is this repository being maintained?
If you want, I can continue maintaining it and make sure I continue what you have created and continue helping the people using it, the same way you had done so far.

Thank you and cheers...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants