Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable examples in CI #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

bednam
Copy link
Contributor

@bednam bednam commented Oct 30, 2020

No description provided.

@bednam bednam force-pushed the mb/enable-examples branch 8 times, most recently from 2a85db2 to d10b5b3 Compare November 6, 2020 15:25
@odisseus
Copy link
Contributor

odisseus commented Nov 10, 2020

Looks like the new test stage has timed out. Try increasing the time limit for that stage.

@bednam
Copy link
Contributor Author

bednam commented Nov 10, 2020

Looks like the new test stage has timed out. Try increasing the time limit for that stage.

It can also be the possible cause for the test suite failure, though test-examples in comparison with other test sets like test-probe behave in a strange way in a couple of ways, for example based on the CI logs:

  • plugins (bundled ideprobe plugin and external robot plugin) are attempted to be installed several times. This is at the same time the place where output stops to be produced.

  • IntelliJ is not being fetched (lack of Fetching ....) nor the appropriate logs like Installing IntelliJVersion(...) are present which is impossible based on the code that is being executed in the IntelliJFactory

The examples seem to work fine locally (with docker and without the docker).

@bednam bednam force-pushed the mb/enable-examples branch 6 times, most recently from 35adc4b to 77eceac Compare November 12, 2020 18:12
@bednam
Copy link
Contributor Author

bednam commented Nov 12, 2020

It appeared that the problem stems from behaviour of parameterized tests API (junit5 and jupiter-interface). Without any thorough analysis, it seems that the runner attempted to execute test cases concurrently. JUnit4 parameterized tests API works fine though.

@bednam bednam force-pushed the mb/enable-examples branch 2 times, most recently from fbf7f68 to 4b9f4fa Compare November 13, 2020 09:29
push:
branches:
- master
- 2020.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed as 2020.3 is in master

@bednam bednam force-pushed the mb/enable-examples branch 6 times, most recently from 13cb9a4 to 4406184 Compare November 16, 2020 10:27
@bednam bednam force-pushed the mb/enable-examples branch 4 times, most recently from 762906f to a7731e4 Compare November 24, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants