Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aliasing of HasMany and ManyToMany relations #81

Closed
wants to merge 2 commits into from
Closed

Fix aliasing of HasMany and ManyToMany relations #81

wants to merge 2 commits into from

Commits on Mar 17, 2021

  1. Fix aliasing of HasMany and ManyToMany relations 

    `buildFilter()` aliases relations that are not OneToOne, but `fullColumnName()` does not, the result being that filters on fields nested in HasMany or ManyToMany relations fail.
This commit makes the `fullColumnName()` method alias all such relations.
    @DeanMauro
    DeanMauro authored Mar 17, 2021
    Configuration menu
    Copy the full SHA
    b2fd65f View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. Separated the predicates in FullColumnName 

    There are 3 cases to consider rather than 2:
1. Is not a relation
2. Is a relation and !isOneToOne
3. Is a relation and isOneToOne
    @DeanMauro
    DeanMauro authored Mar 18, 2021
    Configuration menu
    Copy the full SHA
    0e9f2ab View commit details
    Browse the repository at this point in the history