Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/approve reject #5

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Feature/approve reject #5

wants to merge 19 commits into from

Conversation

zelima
Copy link
Contributor

@zelima zelima commented Dec 4, 2018 •
edited
Loading

  • update is_admin helper to filter by owner_org (used show buttons)
  • approve/reject buttons at the bottom of the package
    • the disqus comment section for feedback (available only if pending/rejected)
  • notify editor package has been rejected
  • controllers to approve/reject
    • check logged in user has perms to delete -> approve/reject

Note: This PR includes all changes from #3 and #4

zelima and others added 19 commits November 28, 2018 13:24
@zelima
[logic][s]: custom validator for state - refs #12
b49437e
@zelima
[views][m]: Note for editors - refs #12
b8cba5a
@zelima
[search][s]: don't show pending packages. refs #12
75395d5
@zelima
[showcase][s]: restrict anonimous users - refs #12
609c793
@zelima
merge master for working tests
0f6cccc
@zelima
[tests][m]: fix broken tests - refs #12
daadd48 
- pass the context to get popular and recently viewed datasets
- update test to pass user name to context
- update layout1 to pass username to helper
- new test case  to cehck only approved datasets are listed
@zelima
[tests][s]: test get_admin
8e63b69
@zelima
[tests][s]: test validators
5e8417e
@zelima
[tests][s]: test package_show
4ea13ff
@zelima
[tidy][m]: tidy logic and code
a7de217 
- get rid of approved
- correct role for readers
@amercader
Make validator logic more robust
5e1c335
@amercader
Fix auth check in package_show
1460cb6
@amercader
Fix tests
1ac9211 
call_action sets ignore_auth=True by default, which basically means that
everybody can `package_update`, so the the check on `package_show`
doesn't work. Also simplified the tests when possible.
@zelima
[tests][m]: tests for each role
3f8d225
@zelima
[tests][s]: state pending for updated packages
5d296b0
@zelima
[search][s]: use IPackageController.before_search
8edd1ad
@zelima
[updated datasets][s]: get rid of package_show
9f0d999
@zelima
[emails][m]: email admins re pending pkgs refs #13
e384084 
- override package_create to send email if approval_pending
- Email template including info about package, user and admin
- tests
@zelima
[actions][m]: approve/reject for admin
4a830fc 
- update is_admin helper to filter by owner_org (used show buttons)
- approve/reject buttons at the bottom of the package
  - discus comment section for feedback (available only if pending/rejected)
- notify editor package has been rejected
- controllers to approve/reject
  - check logged in user has perms to delete -> approve/reject
@zelima zelima assigned amercader and unassigned amercader Dec 4, 2018
@zelima zelima requested a review from amercader December 4, 2018 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amercader amercader Awaiting requested review from amercader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zelima @amercader