Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ad hoc filter replace bug #170

Merged

Conversation

yincongcyincong
Copy link
Contributor

fix #167

@hagen1778
Copy link
Contributor

@dmitryk-dk @Loori-R this looks like a nasty bug. Would appreciate your review and a set of tests to verify the change.

hagen1778
hagen1778 previously approved these changes Jun 24, 2024
Copy link
Contributor

@hagen1778 hagen1778 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dmitryk-dk dmitryk-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good tests are failed because one type was not imported

src/datasource.test.ts Show resolved Hide resolved
Copy link
Contributor

@dmitryk-dk dmitryk-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmitryk-dk dmitryk-dk merged commit 1b06a34 into VictoriaMetrics:main Jun 26, 2024
4 checks passed
@dmitryk-dk
Copy link
Contributor

@yincongcyincong, thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ad-hocs are falsely applied to variables in query
3 participants