Set default Type to instant for alert rules (#207)

* feature: set default Type to instant for alert rules #205 * Update CHANGELOG.md --------- Co-authored-by: Roman Khavronenko <[email protected]>
VictoriaMetrics · Oct 8, 2024 · f2ea5c5 · f2ea5c5
1 parent 3bbac17
commit f2ea5c5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## tip 
 
+* FEATURE: set the default query type to `instant` when creating alerting rules. See [this issue](https://github.com/VictoriaMetrics/victoriametrics-datasource/issues/205).
+
 ## [v0.9.1](https://github.com/VictoriaMetrics/victoriametrics-datasource/releases/tag/v0.9.1)
 
 * BUGFIX: fix parsing dots in the the `label_values` function in the query builder. See [this issue](https://github.com/VictoriaMetrics/victoriametrics-datasource/issues/198).

diff --git a/src/querybuilder/state.ts b/src/querybuilder/state.ts
@@ -42,7 +42,7 @@ export function getQueryWithDefaults(query: PromQuery, app: CoreApp | undefined)
     result = { ...query, editorMode: getDefaultEditorMode(query.expr) };
   }
 
-  if (query.expr == null) {
+  if (!query.expr) {
     result = { ...result, expr: '', legendFormat: LegendFormatMode.Auto };
   }
 
@@ -56,5 +56,10 @@ export function getQueryWithDefaults(query: PromQuery, app: CoreApp | undefined)
     }
   }
 
+  // Unified Alerting does not support "both" for query type – fall back to "range".
+  if (app === CoreApp.UnifiedAlerting) {
+    const isBothInstantAndRange = query.instant && query.range;
+    result = { ...result, range: isBothInstantAndRange, instant: !isBothInstantAndRange };
+  }
   return result;
 }