remove redundant reader

pkg/plugin/response_test.go

@@ -13,20 +13,13 @@ import (
 )
 
 func Test_parseStreamResponse(t *testing.T) {
-	f := func(remoteResp string) io.Reader {
-		return io.NopCloser(bytes.NewBuffer([]byte(remoteResp)))
-	}
 	tests := []struct {
 		name     string
-		reader   func(remoteResp string) io.Reader
 		response string
 		want     func() backend.DataResponse
 	}{
 		{
-			name: "empty response",
-			reader: func(remoteResp string) io.Reader {
-				return io.NopCloser(bytes.NewBuffer([]byte(remoteResp)))
-			},
+			name:     "empty response",
 			response: "",
 			want: func() backend.DataResponse {
 				labelsField := data.NewFieldFromFieldType(data.FieldTypeJSON, 0)
@@ -49,31 +42,27 @@ func Test_parseStreamResponse(t *testing.T) {
 		},
 		{
 			name:     "incorrect response",
-			reader:   f,
 			response: "abcd",
 			want: func() backend.DataResponse {
 				return newResponseError(fmt.Errorf("error decode response: invalid character 'a' looking for beginning of value"), backend.StatusInternal)
 			},
 		},
 		{
 			name:     "incorrect time in the response",
-			reader:   f,
 			response: `{"_time":"acdf"}`,
 			want: func() backend.DataResponse {
 				return newResponseError(fmt.Errorf("error parse time from _time field: cannot parse acdf: cannot parse duration \"acdf\""), backend.StatusInternal)
 			},
 		},
 		{
 			name:     "invalid stream in the response",
-			reader:   f,
 			response: `{"_time":"2024-02-20", "_stream":"{application=\"logs-benchmark-Apache.log-1708437847\",hostname=}"}`,
 			want: func() backend.DataResponse {
 				return newResponseError(fmt.Errorf("StringExpr: unexpected token \"}\"; want \"string\"; unparsed data: \"}\""), backend.StatusInternal)
 			},
 		},
 		{
 			name:     "correct response line",
-			reader:   f,
 			response: `{"_msg":"123","_stream":"{application=\"logs-benchmark-Apache.log-1708437847\",hostname=\"e28a622d7792\"}","_time":"2024-02-20T14:04:27Z"}`,
 			want: func() backend.DataResponse {
 				labelsField := data.NewFieldFromFieldType(data.FieldTypeJSON, 0)
@@ -108,7 +97,6 @@ func Test_parseStreamResponse(t *testing.T) {
 		},
 		{
 			name:     "response with different labels",
-			reader:   f,
 			response: `{"_msg":"123","_stream":"{application=\"logs-benchmark-Apache.log-1708437847\",hostname=\"e28a622d7792\"}","_time":"2024-02-20T14:04:27Z", "job": "vlogs"}`,
 			want: func() backend.DataResponse {
 				labelsField := data.NewFieldFromFieldType(data.FieldTypeJSON, 0)
@@ -145,7 +133,7 @@ func Test_parseStreamResponse(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			r := tt.reader(tt.response)
+			r := io.NopCloser(bytes.NewBuffer([]byte(tt.response)))
 			w := tt.want()
 			if got := parseStreamResponse(r); !reflect.DeepEqual(got, w) {
 				t.Errorf("parseStreamResponse() = %#v, want %#v", got, w)