common: readable error on helm older than 3.14 (#1579)

VictoriaMetrics · Oct 11, 2024 · ac5b2b3 · ac5b2b3
1 parent c5ef805
commit ac5b2b3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/charts/victoria-metrics-common/CHANGELOG.md b/charts/victoria-metrics-common/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 ## Next release
 
-- TODO
+- Display compatibility error message
 
 ## 0.0.14
 

diff --git a/charts/victoria-metrics-common/Chart.yaml b/charts/victoria-metrics-common/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 type: library
 description: Victoria Metrics Common - contains shared templates for all Victoria Metrics helm charts
 name: victoria-metrics-common
-version: 0.0.14
+version: 0.0.15
 sources:
   - https://github.com/VictoriaMetrics/helm-charts
 kubeVersion: ">=1.23.0-0"

diff --git a/charts/victoria-metrics-common/templates/_helpers.tpl b/charts/victoria-metrics-common/templates/_helpers.tpl
@@ -1,6 +1,10 @@
 {{- define "vm.namespace" -}}
   {{- $Release := (.helm).Release | default .Release -}}
   {{- $Values := (.helm).Values | default .Values -}}
+  {{- $Capabilities := (.helm).Capabilities | default .Capabilities -}}
+  {{- if semverCompare "<3.14.0" $Capabilities.HelmVersion.Version }}
+    {{- fail "This chart requires helm version 3.14.0 or higher" }}
+  {{- end }}
   {{- $Values.namespaceOverride | default ($Values.global).namespaceOverride | default $Release.Namespace -}}
 {{- end -}}