Correctly emit protected constructors #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
reviewed
Oct 25, 2023
| @@ -756,6 +756,7 @@ public boolean requiresProtectedConstructor() { | |||
| element.getEnclosedElements().stream() | |||
| .map(enclosedElement -> TsElement.of(enclosedElement, env)) | |||
| .filter(TsElement::isConstructor) | |||
| .filter(tsElement -> !tsElement.isPrivate()) | |||
There was a problem hiding this comment.
as long as you're in here, wouldnt it make more sense to also move the isIgnored filter here - functionally, we filter out ignored and private constructors in the same way (and this list isn't used anywhere else).
Don't even need the list property then, just a findAny().isPresent() to assign to allIgnored?
if a class has a private constructors and all other constructors are ignored, we should be emitting a protected constructor. currently we dont since we dont filter for private constructors. this commit should fix that
vegegoku
force-pushed
the
correctly-emit-protected-ctor
branch
from
f1483f2
to
7a4cdc8
Compare
niloc132
approved these changes
Oct 25, 2023
vegegoku
added a commit
that referenced
this pull request
Oct 29, 2023
if a class has a private constructors and all other constructors are ignored, we should be emitting a protected constructor. currently we dont since we dont filter for private constructors. this commit should fix that (cherry picked from commit 017556c)
vegegoku
added a commit
that referenced
this pull request
Oct 29, 2023
if a class has a private constructors and all other constructors are ignored, we should be emitting a protected constructor. currently we dont since we dont filter for private constructors. this commit should fix that (cherry picked from commit 017556c)
vegegoku
added a commit
that referenced
this pull request
Oct 29, 2023
if a class has a private constructors and all other constructors are ignored, we should be emitting a protected constructor. currently we dont since we dont filter for private constructors. this commit should fix that (cherry picked from commit 017556c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a class has a private constructors and all other constructors are ignored, we should be emitting a protected constructor. currently we dont since we dont filter for private constructors. this commit should fix that