Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shaded jars do not include jsinterop-annotations, and do not depend on them #89

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Shaded jars do not include jsinterop-annotations, and do not depend on them #89

merged 1 commit into from
Oct 24, 2023

Conversation

vegegoku
Copy link
Member

Fix #86

@vegegoku vegegoku added the bug Something isn't working label Oct 22, 2023
@vegegoku vegegoku added this to the 1.0.0 milestone Oct 22, 2023
@vegegoku vegegoku self-assigned this Oct 22, 2023
niloc132
niloc132 reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm, this only makes sure that the dependencies are added, rather than making them shaded into the jar?

@vegegoku
Copy link
Member Author

To confirm, this only makes sure that the dependencies are added, rather than making them shaded into the jar?

Yes, they should not be shaded
https://github.com/Vertispan/jsinterop-ts-defs/blob/main/jsinterop-ts-defs-processor/pom.xml#L82

@niloc132 niloc132 merged commit c73bc10 into Vertispan:main Oct 24, 2023
2 checks passed
vegegoku added a commit that referenced this pull request Oct 29, 2023
@vegegoku
Shaded jars do not include jsinterop-annotations, and do not depend o…
9fa1666 
…n them (#89)

Fix #86

(cherry picked from commit c73bc10)
vegegoku added a commit that referenced this pull request Oct 29, 2023
@vegegoku
Shaded jars do not include jsinterop-annotations, and do not depend o…
2fcc240 
…n them (#89)

Fix #86

(cherry picked from commit c73bc10)
vegegoku added a commit that referenced this pull request Oct 29, 2023
@vegegoku
Shaded jars do not include jsinterop-annotations, and do not depend o…
797890b 
…n them (#89)

Fix #86

(cherry picked from commit c73bc10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niloc132 niloc132 niloc132 approved these changes

Assignees

@vegegoku vegegoku

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Shaded jars do not include jsinterop-annotations, and do not depend on them
2 participants
@vegegoku @niloc132