Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEN-1214][VEN-1150]: integrate ACM and automatic reduce reserves in VToken #262

Merged
merged 47 commits into from
Oct 31, 2023

Conversation

GitGuru7
Copy link
Contributor

@GitGuru7 GitGuru7 commented May 10, 2023

Description

  • Upgrade the implementation of the markets, replacing the check of admin with the use of the AccessControlManager in the following functions:
    _setReserveFactor
    _reduceReserves
    _setInterestRateModel

  • It also include Automatic reserve allocation feature

  • Added test operations of mint, redeem, repay and borrow and checked storage layouts before and after upgrade of the VToken for every market

Resolves VEN-1214, VEN-1150

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@GitGuru7 GitGuru7 self-assigned this May 10, 2023
@GitGuru7 GitGuru7 marked this pull request as draft May 10, 2023 15:31
@GitGuru7 GitGuru7 marked this pull request as ready for review May 16, 2023 13:37
@GitGuru7 GitGuru7 changed the title [VEN-1214]: integrate ACM in vToken [VEN-1214][VEN-1150]: integrate ACM and automatic reduce reserves in VToken Jun 8, 2023
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
Admin 88% 41%
Comptroller 100% 90%
Comptroller.Diamond 95% 59%
Comptroller.Diamond.facets 73% 62%
Comptroller.Diamond.interfaces 100% 100%
DelegateBorrowers 100% 86%
Governance 0% 0%
InterestRateModels 0% 0%
Lens 44% 37%
Liquidator 99% 89%
Oracle 100% 100%
PegStability 88% 84%
Swap 92% 58%
Swap.interfaces 100% 100%
Swap.lib 81% 53%
Tokens 100% 100%
Tokens.VAI 71% 46%
Tokens.VRT 20% 9%
Tokens.VTokens 41% 22%
Tokens.XVS 19% 8%
Utils 48% 29%
VRTVault 49% 36%
Vault 50% 45%
XVSVault 62% 49%
Summary 59% (2177 / 3681) 42% (851 / 2010)

@chechu chechu removed the audit This content is being audited label Oct 25, 2023
@GitGuru7 GitGuru7 merged commit 927c2f9 into develop Oct 31, 2023
3 checks passed
@chechu chechu mentioned this pull request Oct 31, 2023
@kkirka kkirka deleted the feature/VEN-1214 branch November 29, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants