Replace BnStrCompatible
with AsCStr
trait
#5897
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rather large PR, but the essence of the changes is in
string.rs
. Replaces theBnStrCompatible
trait with anAsCStr
trait with the following definition:Note that this trait borrows
&self
instead of consumingself
. This simplifies the list of implementing types and reduces the need for cloning. Theas_cstr
method returns aCow
in order to provide implementations both for already null-terminated strings (BnString
) and for non-terminated strings (&str
/String
).Note that it is still possible in some cases to create a pointer to a temporary that gets immediately dropped if calling
s.as_cstr().as_ptr()
inline, same as withBnStrCompatible
. I was careful to avoid doing so when swapping out the traits.